Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add stats config for load tests #11868

Merged
merged 1 commit into from
Apr 14, 2020
Merged

Add stats config for load tests #11868

merged 1 commit into from
Apr 14, 2020

Conversation

ijjk
Copy link
Member

@ijjk ijjk commented Apr 14, 2020 •
edited
Loading

This adds the config to load test specific pages with next start in our PR stats. This will help us prevent regressing on page load performance without catching it since we will be able to see it at a PR level before merging.

x-ref: #11819
x-ref: #11867

@ijjk ijjk added this to the 9.3.5 milestone Apr 14, 2020
@ijjk
Copy link
Member Author

ijjk commented Apr 14, 2020 •
edited
Loading

Stats from current PR

Default Server Mode (Decrease detected ✓)
General
zeit/next.js canary ijjk/next.js add/load-test-config Change
buildDuration 11s 11.4s ⚠️ +348ms
nodeModulesSize 55.5 MB 55.5 MB ✓
Page Load Tests Overall decrease ⚠️
zeit/next.js canary ijjk/next.js add/load-test-config Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.263 2.35 ⚠️ +0.09
/ avg req/sec 1104.89 1063.82 -41.07
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.298 1.276 -0.02
/error-in-render avg req/sec 1926.04 1959.58 ⚠️ +33.54
Client Bundles (main, webpack, commons)
zeit/next.js canary ijjk/next.js add/load-test-config Change
main-HASH.js gzip 6.25 kB 6.25 kB ✓
webpack-HASH.js gzip 746 B 746 B ✓
de003c3a9d30..a4ac.js gzip 10.2 kB 10.2 kB ✓
framework.HASH.js gzip 39.1 kB 39.1 kB ✓
Overall change 56.3 kB 56.3 kB ✓
Client Bundles (main, webpack, commons) Modern
zeit/next.js canary ijjk/next.js add/load-test-config Change
main-HASH.module.js gzip 4.78 kB 4.78 kB ✓
webpack-HASH..dule.js gzip 746 B 746 B ✓
de003c3a9d30..dule.js gzip 6.78 kB 6.78 kB ✓
framework.HA..dule.js gzip 39.1 kB 39.1 kB ✓
Overall change 51.5 kB 51.5 kB ✓
Legacy Client Bundles (polyfills)
zeit/next.js canary ijjk/next.js add/load-test-config Change
polyfills-HASH.js gzip 26.3 kB 26.3 kB ✓
Overall change 26.3 kB 26.3 kB ✓
Client Pages
zeit/next.js canary ijjk/next.js add/load-test-config Change
_app.js gzip 1.24 kB 1.24 kB ✓
_error.js gzip 3.15 kB 3.15 kB ✓
hooks.js gzip 664 B 664 B ✓
index.js gzip 222 B 222 B ✓
link.js gzip 2.03 kB 2.03 kB ✓
routerDirect.js gzip 279 B 279 B ✓
withRouter.js gzip 278 B 278 B ✓
Overall change 7.86 kB 7.86 kB ✓
Client Pages Modern
zeit/next.js canary ijjk/next.js add/load-test-config Change
_app.module.js gzip 594 B 594 B ✓
_error.module.js gzip 2.08 kB 2.08 kB ✓
hooks.module.js gzip 370 B 370 B ✓
index.module.js gzip 212 B 212 B ✓
link.module.js gzip 1.48 kB 1.48 kB ✓
routerDirect..dule.js gzip 271 B 271 B ✓
withRouter.m..dule.js gzip 270 B 270 B ✓
Overall change 5.28 kB 5.28 kB ✓
Client Build Manifests
zeit/next.js canary ijjk/next.js add/load-test-config Change
_buildManifest.js gzip 61 B 61 B ✓
_buildManife..dule.js gzip 61 B 61 B ✓
Overall change 122 B 122 B ✓
Rendered Page Sizes
zeit/next.js canary ijjk/next.js add/load-test-config Change
index.html gzip 927 B 927 B ✓
link.html gzip 935 B 935 B ✓
withRouter.html gzip 922 B 922 B ✓
Overall change 2.78 kB 2.78 kB ✓
Serverless Mode
General
zeit/next.js canary ijjk/next.js add/load-test-config Change
buildDuration 12.3s 12.1s -223ms
nodeModulesSize 55.5 MB 55.5 MB ✓
Client Bundles (main, webpack, commons)
zeit/next.js canary ijjk/next.js add/load-test-config Change
main-HASH.js gzip 6.25 kB 6.25 kB ✓
webpack-HASH.js gzip 746 B 746 B ✓
de003c3a9d30..a4ac.js gzip 10.2 kB 10.2 kB ✓
framework.HASH.js gzip 39.1 kB 39.1 kB ✓
Overall change 56.3 kB 56.3 kB ✓
Client Bundles (main, webpack, commons) Modern
zeit/next.js canary ijjk/next.js add/load-test-config Change
main-HASH.module.js gzip 4.78 kB 4.78 kB ✓
webpack-HASH..dule.js gzip 746 B 746 B ✓
de003c3a9d30..dule.js gzip 6.78 kB 6.78 kB ✓
framework.HA..dule.js gzip 39.1 kB 39.1 kB ✓
Overall change 51.5 kB 51.5 kB ✓
Legacy Client Bundles (polyfills)
zeit/next.js canary ijjk/next.js add/load-test-config Change
polyfills-HASH.js gzip 26.3 kB 26.3 kB ✓
Overall change 26.3 kB 26.3 kB ✓
Client Pages
zeit/next.js canary ijjk/next.js add/load-test-config Change
_app.js gzip 1.24 kB 1.24 kB ✓
_error.js gzip 3.15 kB 3.15 kB ✓
hooks.js gzip 664 B 664 B ✓
index.js gzip 222 B 222 B ✓
link.js gzip 2.03 kB 2.03 kB ✓
routerDirect.js gzip 279 B 279 B ✓
withRouter.js gzip 278 B 278 B ✓
Overall change 7.86 kB 7.86 kB ✓
Client Pages Modern
zeit/next.js canary ijjk/next.js add/load-test-config Change
_app.module.js gzip 594 B 594 B ✓
_error.module.js gzip 2.08 kB 2.08 kB ✓
hooks.module.js gzip 370 B 370 B ✓
index.module.js gzip 212 B 212 B ✓
link.module.js gzip 1.48 kB 1.48 kB ✓
routerDirect..dule.js gzip 271 B 271 B ✓
withRouter.m..dule.js gzip 270 B 270 B ✓
Overall change 5.28 kB 5.28 kB ✓
Client Build Manifests
zeit/next.js canary ijjk/next.js add/load-test-config Change
_buildManifest.js gzip 61 B 61 B ✓
_buildManife..dule.js gzip 61 B 61 B ✓
Overall change 122 B 122 B ✓
Serverless bundles
zeit/next.js canary ijjk/next.js add/load-test-config Change
_error.js 557 kB 557 kB ✓
404.html 4.18 kB 4.18 kB ✓
hooks.html 3.81 kB 3.81 kB ✓
index.js 557 kB 557 kB ✓
link.js 593 kB 593 kB ✓
routerDirect.js 586 kB 586 kB ✓
withRouter.js 586 kB 586 kB ✓
Overall change 2.89 MB 2.89 MB ✓

Timer
Timer approved these changes Apr 14, 2020
View reviewed changes
Copy link
Member

@Timer Timer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:approved: x 1000

@Timer Timer merged commit 0b51b23 into vercel:canary Apr 14, 2020
@Timer Timer deleted the add/load-test-config branch April 14, 2020 02:00
This was referenced Apr 17, 2020
Merged
Merged
Closed
@vercel vercel locked as resolved and limited conversation to collaborators Jan 31, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Timer Timer Timer approved these changes

@lfades lfades Awaiting requested review from lfades

@timneutkens timneutkens Awaiting requested review from timneutkens

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
9.3.5
Development

Successfully merging this pull request may close these issues.
2 participants
@ijjk @Timer